Skip to content

chore(l1,l2): compilation with AVX2 feature in linux x86-64 #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

chore(l1,l2): compilation with AVX2 feature in linux x86-64 #5181

wants to merge 9 commits into from
+13 −7

Conversation

@pablodeymo
Copy link
Contributor

@pablodeymo pablodeymo commented Nov 4, 2025

Motivation

Description

Closes #issue_number

@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Nov 4, 2025
azteca1998
azteca1998 reviewed Nov 4, 2025
View reviewed changes
.cargo/config.toml Outdated
Comment on lines 3 to 5
"-Ctarget-cpu=x86-64-v2",
"-Csha2_backend=x86-avx2",
"-Ctarget-feature=+avx2",
Copy link
Contributor

@azteca1998 azteca1998 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just specifying x86-64-v3 is better? According to wikipedia, it is basically what we need.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025 •
edited
Loading

Benchmark Results Comparison

No significant difference was registered for any benchmark run.

Detailed Results

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
main_revm_BubbleSort 2.964 ± 0.008 2.956 2.979 1.00 ± 0.01
main_levm_BubbleSort 3.201 ± 0.019 3.184 3.236 1.08 ± 0.01
pr_revm_BubbleSort 2.958 ± 0.016 2.946 2.992 1.00
pr_levm_BubbleSort 3.204 ± 0.018 3.186 3.247 1.08 ± 0.01

Benchmark Results: ERC20Approval

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Approval 969.5 ± 10.7 961.4 996.1 1.01 ± 0.01
main_levm_ERC20Approval 1155.3 ± 16.7 1136.6 1194.3 1.20 ± 0.02
pr_revm_ERC20Approval 963.3 ± 7.5 954.8 978.1 1.00
pr_levm_ERC20Approval 1152.0 ± 4.3 1145.7 1158.5 1.20 ± 0.01

Benchmark Results: ERC20Mint

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Mint 133.7 ± 1.6 132.0 137.5 1.00 ± 0.01
main_levm_ERC20Mint 167.7 ± 2.8 165.7 175.5 1.26 ± 0.02
pr_revm_ERC20Mint 133.3 ± 0.4 132.7 133.9 1.00
pr_levm_ERC20Mint 167.4 ± 1.6 165.7 171.2 1.26 ± 0.01

Benchmark Results: ERC20Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Transfer 231.3 ± 1.7 229.2 233.7 1.00 ± 0.01
main_levm_ERC20Transfer 286.2 ± 6.3 280.3 302.0 1.24 ± 0.03
pr_revm_ERC20Transfer 231.2 ± 2.2 228.6 235.1 1.00
pr_levm_ERC20Transfer 287.5 ± 5.5 283.6 301.8 1.24 ± 0.03

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Factorial 227.2 ± 0.7 226.2 228.4 1.01 ± 0.01
main_levm_Factorial 268.4 ± 1.9 265.3 271.5 1.19 ± 0.01
pr_revm_Factorial 225.4 ± 1.0 223.5 226.8 1.00
pr_levm_Factorial 270.7 ± 1.9 268.4 274.5 1.20 ± 0.01

Benchmark Results: FactorialRecursive

Command Mean [s] Min [s] Max [s] Relative
main_revm_FactorialRecursive 1.602 ± 0.057 1.515 1.687 1.00 ± 0.04
main_levm_FactorialRecursive 8.535 ± 0.049 8.461 8.615 5.33 ± 0.12
pr_revm_FactorialRecursive 1.602 ± 0.034 1.559 1.648 1.00
pr_levm_FactorialRecursive 8.507 ± 0.049 8.441 8.575 5.31 ± 0.12

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Fibonacci 208.4 ± 0.9 207.3 210.3 1.01 ± 0.01
main_levm_Fibonacci 262.0 ± 3.9 255.9 265.5 1.27 ± 0.02
pr_revm_Fibonacci 206.7 ± 0.9 205.7 208.8 1.00
pr_levm_Fibonacci 266.3 ± 5.5 258.9 277.1 1.29 ± 0.03

Benchmark Results: FibonacciRecursive

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_FibonacciRecursive 843.8 ± 11.8 826.6 860.8 1.11 ± 0.02
main_levm_FibonacciRecursive 772.6 ± 4.8 767.1 785.1 1.01 ± 0.02
pr_revm_FibonacciRecursive 829.9 ± 15.5 816.3 855.5 1.09 ± 0.03
pr_levm_FibonacciRecursive 762.5 ± 11.1 737.5 783.6 1.00

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ManyHashes 8.4 ± 0.1 8.2 8.5 1.01 ± 0.01
main_levm_ManyHashes 9.6 ± 0.1 9.5 9.9 1.16 ± 0.01
pr_revm_ManyHashes 8.3 ± 0.0 8.2 8.4 1.00
pr_levm_ManyHashes 9.6 ± 0.1 9.5 9.7 1.15 ± 0.01

Benchmark Results: MstoreBench

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_MstoreBench 266.8 ± 4.5 263.3 276.9 1.13 ± 0.02
main_levm_MstoreBench 236.7 ± 1.6 234.1 238.9 1.00
pr_revm_MstoreBench 264.9 ± 2.7 263.2 272.3 1.12 ± 0.01
pr_levm_MstoreBench 238.5 ± 6.9 233.8 256.7 1.01 ± 0.03

Benchmark Results: Push

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Push 290.0 ± 3.5 286.2 298.5 1.01 ± 0.02
main_levm_Push 307.4 ± 1.7 306.1 310.8 1.07 ± 0.01
pr_revm_Push 286.9 ± 2.7 285.0 294.3 1.00
pr_levm_Push 302.9 ± 1.5 300.9 305.9 1.06 ± 0.01

Benchmark Results: SstoreBench_no_opt

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_SstoreBench_no_opt 172.1 ± 5.7 166.2 185.5 1.91 ± 0.09
main_levm_SstoreBench_no_opt 89.9 ± 2.8 87.9 97.0 1.00
pr_revm_SstoreBench_no_opt 176.3 ± 7.7 166.4 190.6 1.96 ± 0.11
pr_levm_SstoreBench_no_opt 91.2 ± 4.1 86.3 99.6 1.01 ± 0.06

@jrchatruc jrchatruc marked this pull request as ready for review November 5, 2025 15:37
@jrchatruc jrchatruc requested a review from a team as a code owner November 5, 2025 15:37
Copilot AI review requested due to automatic review settings November 5, 2025 15:41
@pablodeymo
Copy link
Contributor Author

pablodeymo commented Nov 5, 2025

Superseded by #5189 5189

@pablodeymo pablodeymo closed this Nov 5, 2025
@github-project-automation github-project-automation bot moved this to Done in ethrex_l1 Nov 5, 2025
@github-project-automation github-project-automation bot moved this to Done in ethrex_l2 Nov 5, 2025
@pablodeymo pablodeymo deleted the avx2 branch November 5, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azteca1998 azteca1998 azteca1998 left review comments

Copilot code review Copilot Awaiting requested review from Copilot

Assignees

@pablodeymo pablodeymo

Labels

L1 Ethereum client L2 Rollup client

Projects

ethrex_l1
Status: Done
ethrex_l2
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablodeymo @azteca1998